Re: [PATCH] firmware: Always initialize the fw_priv list object

On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote:

When freeing the fw_priv the item is taken off the list. This causes an oops in the FW_OPT_NOCACHE case as the list object is not initialized.

Make sure to initialize the list object regardless of this flag.

Fixes: 422b3db2a503 ("firmware: Fix security issue with request_firmware_into_buf()") Cc: stable@vger.kernel.org Cc: Rishabh Bhatnagar rishabhb@codeaurora.org Signed-off-by: Bjorn Andersson bjorn.andersson@linaro.org

---

drivers/base/firmware_loader/main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

Is this being triggered by some hardware somewhere today? Or is this just a fix found by code inspection?

thanks,

greg k-h