On 22/08/2025 10:28, Yao Zi wrote:
On Thu, Aug 21, 2025 at 09:54:08AM +0200, Krzysztof Kozlowski wrote:
On Wed, Aug 20, 2025 at 07:42:43AM +0000, Yao Zi wrote:
The reset controller driver for the TH1520 was using the generic compatible string "thead,th1520-reset". However, the controller described by this compatible only manages the resets for the Video Output (VO) subsystem.
Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patche...
Thanks for your review, I appreciate it and will stick to thead,th1520-reset for the VO reset controller.
But I'm not very clear about the subject prefix: I already have a "dt-bindings: reset: " prefix, should I also make the subject more precise, including the exact file changed when changing a binding file?
Yes, as you can check in other commits. Your subject claims that you change " Scope the compatible to VO subsystem explicitly" for all reset controllers.
I've seen commits either with or without the precise name of the changed binding in subjects. For example,
a341bcfbfa7 dt-bindings: reset: add compatible for bcm63xx ephy control
But it says bcm63xx at least. Well, you will find plenty of poor examples as well. I gave you template response because you made typical mistake.
Anyway, you ignored rest of my response, so I assume you agree with it completely.
Best regards, Krzysztof