Re: [PATCH v2 RESEND] EDAC/ti: Fix possible null pointer dereference in _emif_get_id()

On Wed, Jul 24, 2024 at 03:10:42PM +0800, Ma Ke wrote:

In _emif_get_id(), of_get_address() may return NULL which is later dereferenced. Fix this bug by adding NULL check.

Cc: stable@vger.kernel.org Fixes: 86a18ee21e5e ("EDAC, ti: Add support for TI keystone and DRA7xx EDAC") Signed-off-by: Ma Ke make24@iscas.ac.cn

---

Changes in v2:

• added Cc stable line.

---

drivers/edac/ti_edac.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c index 29723c9592f7..db23887b2d81 100644 --- a/drivers/edac/ti_edac.c +++ b/drivers/edac/ti_edac.c @@ -207,6 +207,9 @@ static int _emif_get_id(struct device_node *node) int my_id = 0; addrp = of_get_address(node, 0, NULL, NULL);

• if (!addrp)

• return -EINVAL;
  

How was this found?

How was this tested?

thanks,

greg k-h