On Fri, Sep 13, 2019 at 10:46 AM Sasha Levin sashal@kernel.org wrote:
On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote:
Hi Greg,
This feels like it's missing a From: line.
commit b513a18cf1d705bd04efd91c417e79e4938be093 Author: Lyude Paul lyude@redhat.com Date: Mon Jan 28 16:03:50 2019 -0500
drm/nouveau: Don't WARN_ON VCPI allocation failures
Is this an artifact of your notification-of-patches process and I never noticed before, or was the patch ingested incorrectly?
It was always like this for patches that came through me. Greg's script generates an explicit "From:" line in the patch, but I never saw the value in that since git does the right thing by looking at the "From:" line in the mail header.
That's right -- the email's From header gets used in the case of no explicit From in the email body. But Greg is sending the emails From: Greg, so if I were to ingest that email, I would end up with a patch From: Greg, not From: Lyude as it ought to be.
Cheers,
-ilia