Re: [PATCH v4 1/2] mm_take_all_locks: change -EINTR to -ERESTARTSYS

On Wed, 7 Jan 2026, Matthew Wilcox wrote:

On Wed, Jan 07, 2026 at 09:31:14PM +0100, Mikulas Patocka wrote:

...

This commit changes -EINTR to -ERESTARTSYS, so that if the signal handler was installed with the SA_RESTART flag, the operation is automatically restarted.

No, this is bonkers. If you get a signal, you return -EINTR.

Why?

fifo_open returns -ERESTARTSYS, so why not here?

Mikulas