25 Aug
2025
25 Aug
'25
4:22 a.m.
On 2025/8/25 11:59, Finn Thain wrote:
On Mon, 25 Aug 2025, Lance Yang wrote:
However, as we've seen from the kernel test robot's report on mt6660_chip, this won't solve the cases where a lock is forced to be unaligned by #pragma pack(1). That will still trigger warnings, IIUC.
I think you've misunderstood the warning that your patch produced. (BTW, I have not seen any warnings from my own patch, so far.)
The mistake you made in your patch was to add an alignment attribute to a member of a packed struct. That's why I suggested that you should align the lock instead.
Apologies for the confusion. I was referring to the runtime warning from WARN_ON_ONCE, not a compile-time warning.