On Tue, 28 Jul 2020 at 18:33, Muchun Song songmuchun@bytedance.com wrote:
Thanks for your test. I have reviewed the patch:
[PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
There is a backport problem and I have pointed out the problem in that email.
Thanks for your suggestions on the other email thread. I have made changes as you said and boot test pass on x86 now.
diff --git a/mm/slab_common.c b/mm/slab_common.c index 9c5eb4b08fc3..65bc49f19504 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -842,9 +842,7 @@ static int shutdown_memcg_caches(struct kmem_cache *s)
static void memcg_set_kmem_cache_dying(struct kmem_cache *s) { - mutex_lock(&slab_mutex); s->memcg_params.dying = true; - mutex_unlock(&slab_mutex); }
static void flush_memcg_workqueue(struct kmem_cache *s)
- Naresh