On Fri, Jun 07, 2024 at 04:05:10PM +0000, Joy Chakraborty wrote:
reg_read() callback registered with nvmem core expects 0 on success and a negative value on error but rmem_read() returns the number of bytes read which is treated as an error at the nvmem core.
This does not break when rmem is accessed using sysfs via bin_attr_nvmem_read()/write() but causes an error when accessed from places like nvmem_access_with_keepouts(), etc.
Change to return 0 on success and error in case memory_read_from_buffer() returns an error or -EIO if bytes read do not match what was requested.
Fixes: 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvmem") Cc: stable@vger.kernel.org Signed-off-by: Joy Chakraborty joychakr@google.com
Thanks!
Reviewed-by: Dan Carpenter dan.carpenter@linaro.org
You mentioned some other functions that had similar bugs. Could you fix those as well.
regards, dan carpenter