5.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dmitry Safonov dima@arista.com
[ Upstream commit 3dd923f39a03dede001afe0edcc08613d5f403e5 ]
`sp' is a needless excercise here.
Signed-off-by: Dmitry Safonov dima@arista.com Signed-off-by: Andrew Morton akpm@linux-foundation.org Cc: Anton Ivanov anton.ivanov@cambridgegreys.com Cc: Jeff Dike jdike@addtoit.com Cc: Richard Weinberger richard@nod.at Link: http://lkml.kernel.org/r/20200418201944.482088-36-dima@arista.com Signed-off-by: Linus Torvalds torvalds@linux-foundation.org Stable-dep-of: 0f659ff362ea ("um: Always dump trace for specified task in show_stack") Signed-off-by: Sasha Levin sashal@kernel.org --- arch/um/kernel/sysrq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c index c71b5ef7ea8c3..c831a1c2eb94a 100644 --- a/arch/um/kernel/sysrq.c +++ b/arch/um/kernel/sysrq.c @@ -27,7 +27,6 @@ static const struct stacktrace_ops stackops = {
void show_stack(struct task_struct *task, unsigned long *stack) { - unsigned long *sp = stack; struct pt_regs *segv_regs = current->thread.segv_regs; int i;
@@ -38,10 +37,9 @@ void show_stack(struct task_struct *task, unsigned long *stack) }
if (!stack) - sp = get_stack_pointer(task, segv_regs); + stack = get_stack_pointer(task, segv_regs);
pr_info("Stack:\n"); - stack = sp; for (i = 0; i < 3 * STACKSLOTS_PER_LINE; i++) { if (kstack_end(stack)) break;