On Tue, Sep 03, 2019 at 09:53:46AM -0700, Jerry Snitselaar wrote:
On Tue Sep 03 19, Doug Anderson wrote:
Hi,
On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin sashal@kernel.org wrote:
From: Vadim Sukhomlinov sukhomlinov@google.com
[ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ]
TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that future TPM operations are disabled.
Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.") Cc: stable@vger.kernel.org Signed-off-by: Vadim Sukhomlinov sukhomlinov@google.com [dianders: resolved merge conflicts with mainline] Signed-off-by: Douglas Anderson dianders@chromium.org Reviewed-by: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com Signed-off-by: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com Signed-off-by: Sasha Levin sashal@kernel.org
drivers/char/tpm/tpm-chip.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Jarkko: did you deal with the issues that came up in response to my post? Are you happy with this going into 4.19 stable at this point? I notice this has your Signed-off-by so maybe?
I think that is just the signed-off-by chain coming from the upstream patch. Jarkko mentioned getting to the backports after Linux Plumbers, which is next week.
Right. I gave a go at backporting a few patches and this happens to be one of them. It will be a while before it goes in a stable tree (probably way after after LPC).
-- Thanks, Sasha