Re: [PATCH v2] PCI: rockchip: Use 64-bit mask on MSI 64-bit PCI address

On Mon, Jul 3, 2023 at 2:08 PM Krzysztof Wilczyński kw@linux.com wrote:

Hello,

...

...

A 32-bit mask was used on the 64-bit PCI address used for mapping MSIs. This would result in the upper 32 bits being unintentionally zeroed and MSIs getting mapped to incorrect PCI addresses if the address had any of the upper bits set.

Replace 32-bit mask by appropriate 64-bit mask.

[...]

...

...

+#define PCIE_ADDR_MASK GENMASK(63, MIN_AXI_ADDR_BITS_PASSED)

Nit: this probably wants to be GENMASK_ULL(), otherwise it might throw a warning if compile-tested for 32-bit.

I can change this to GENMASK_ULL() when I apply the patch. Unless Rick wants to send v3 - either way would be fine. :)

    Krzysztof

Thank you, I'd appreciate that rather than sending a v3.

Regards, Rick