On Tue, Nov 19, 2024 at 10:13:11AM +0800, quic_zijuhu wrote:
On 11/18/2024 8:43 PM, Johan Hovold wrote:
On Sat, Nov 16, 2024 at 07:49:23AM -0800, Zijun Hu wrote:
For WCN6855, board ID specific NVM needs to be downloaded once board ID is available, but the default NVM is always downloaded currently, and the wrong NVM causes poor RF performance which effects user experience.
Fix by downloading board ID specific NVM if board ID is available.
Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855") Cc: stable@vger.kernel.org # 6.4 Reviewed-by: Johan Hovold johan+linaro@kernel.org
When making non-trivial changes, like the addition of the fallback NVM feature in v2, you should probably have dropped any previous Reviewed-by tags.
make sense. will notice these aspects for further patches.
The fallback handling looks good to me though (and also works as expected).
so, is it okay to make this patch still keep tags given by you ?
Yes, it's fine to keep my Reviewed-by and Tested-by tags.
Tested-by: Johan Hovold johan+linaro@kernel.org Tested-by: Steev Klimaszewski steev@kali.org Tested-by: Jens Glathe jens.glathe@oldschoolsolutions.biz Signed-off-by: Zijun Hu quic_zijuhu@quicinc.com
Changes in v2:
- Correct subject and commit message
- Temporarily add nvm fallback logic to speed up backport.
— Add fix/stable tags as suggested by Luiz and Johan
If you think it's ok for people to continue using the wrong (default) NVM file for a while still until their distros ship the board-specific ones, then this looks good to me and should ease the transition:
yes. i think it is okay now.
Then I think this patch is ready to be merged.
Thanks again for your help with this.
Johan