Re: [PATCH net v3 1/2] net: dsa: microchip: let phylink manage PHY EEE configuration on KSZ switches

On Tue, 29 Apr 2025 09:36:43 +0200 Oleksij Rempel wrote:

switch (dev->chip_id) { case KSZ8563_CHIP_ID:

• case KSZ9563_CHIP_ID:
• case KSZ9893_CHIP_ID:

• return true;
  

  case KSZ8567_CHIP_ID:

• /* KSZ8567R Errata DS80000752C Module 4 */
  

• case KSZ8765_CHIP_ID:
• case KSZ8794_CHIP_ID:
• case KSZ8795_CHIP_ID:

• /* KSZ879x/KSZ877x/KSZ876x Errata DS80000687C Module 2 */
  

  case KSZ9477_CHIP_ID:

• case KSZ9563_CHIP_ID:

• /* KSZ9477S Errata DS80000754A Module 4 */
  

  case KSZ9567_CHIP_ID:

• case KSZ9893_CHIP_ID:

• /* KSZ9567S Errata DS80000756A Module 4 */
  

  case KSZ9896_CHIP_ID:

• /* KSZ9896C Errata DS80000757A Module 3 */
  

  case KSZ9897_CHIP_ID: case LAN9646_CHIP_ID:

• return true;
  

• /* KSZ9897R Errata DS80000758C Module 4 */
  

• /* Energy Efficient Ethernet (EEE) feature select must be
  

•  * manually disabled
  

•  *   The EEE feature is enabled by default, but it is not fully
  

•  *   operational. It must be manually disabled through register
  

•  *   controls. If not disabled, the PHY ports can auto-negotiate
  

•  *   to enable EEE, and this feature can cause link drops when
  

•  *   linked to another device supporting EEE.
  

•  *
  

•  * The same item appears in the errata for all switches above.
  

•  */
  

  }

compilers are not on board with having labels right before the closing bracket. Please add a 'break;' here?

drivers/net/dsa/microchip/ksz_common.c:3565:9: warning: statement expected after case label

reminder: we have a 24h cool down period between reposts