On Thu, 5 Nov 2020 at 12:46, Pavel Machek pavel@ucw.cz wrote:
Hi!
The Power Management Unit (PMU) is a separate device which has little common with clock controller. Moving it to one level up (from clock controller child to SoC) allows to remove fake simple-bus compatible and dtbs_check warnings like:
clock-controller@e0100000: $nodename:0: 'clock-controller@e0100000' does not match '^([a-z][a-z0-9\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
+++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -98,19 +98,16 @@ };
clocks: clock-controller@e0100000 {
compatible = "samsung,s5pv210-clock", "simple-bus";
compatible = "samsung,s5pv210-clock"; reg = <0xe0100000 0x10000>;...
pmu_syscon: syscon@e0108000 {compatible = "samsung-s5pv210-pmu", "syscon";reg = <0xe0108000 0x8000>; };Should clock-controller@e0100000's reg be shortened to 0x8000 so that the ranges do not overlap?
Signed-off-by: Pavel Machek (CIP) pavel@denx.de
I don't think this commit should be backported to stable. It is simple dtbs_check - checking whether Devicetree source matches device tree schema. Neither the schema nor the warning existed in v4.19. I think dtbs_check fixes should not be backported, unless a real issue is pointed out.
Best regards, Krzysztof