Re: [PATCH v2] mm/shmem: fix THP allocation and fallback loop

diff --git a/mm/shmem.c b/mm/shmem.c index b50ce7dbc84a..7559773ebb30 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1895,10 +1895,11 @@ static struct folio *shmem_alloc_and_add_folio(struct vm_fault *vmf, order = highest_order(suitable_orders); while (suitable_orders) { pages = 1UL << order;

•                   index = round_down(index, pages);
  

•                   folio = shmem_alloc_folio(gfp, order, info, index);
  

•                   if (folio)
  

•                   folio = shmem_alloc_folio(gfp, order, info, round_down(index, pages));
  

•                   if (folio) {
  

•                           index = round_down(index, pages);
                            goto allocated;
  

•                   }
  

Could this be a temporary variable to store round_down(index, pages)?

                    if (pages == HPAGE_PMD_NR)
                            count_vm_event(THP_FILE_FALLBACK);

--

Thanks Barry