From: Alexander Stein alexander.stein@ew.tq-group.com
[ Upstream commit 00ea54f058cd4cb082302fe598cfe148e0aadf94 ]
This driver is licensed GPL-2.0-only, so add the corresponding module flag.
Signed-off-by: Alexander Stein alexander.stein@ew.tq-group.com Link: https://lore.kernel.org/r/20250725071153.338912-3-alexander.stein@ew.tq-grou... Signed-off-by: Lee Jones lee@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
YES
**What Changed** - Adds missing module license declaration: `MODULE_LICENSE("GPL");` in drivers/mfd/stmpe-i2c.c:129.
**Why It Matters** - Without a `MODULE_LICENSE`, modules are treated as non‑GPL compatible, which taints the kernel and blocks access to GPL‑only exports: - License compatibility check: include/linux/license.h:5 treats `"GPL"` as GPL‑compatible. - Taint on unknown/non‑GPL licenses: kernel/module/main.c:1742 triggers `TAINT_PROPRIETARY_MODULE` when license isn’t GPL‑compatible. - The driver carries the SPDX header `GPL-2.0-only`, so the module flag aligns metadata with the actual license. - Avoids user‑visible nuisance: dmesg warning and kernel taint on load for this module when built as a module.
**Scope and Risk** - One-line metadata-only change in a single file; no functional or architectural changes. - Very low regression risk; does not modify probe/remove paths or data flows.
**Context and History** - The driver is modular-capable: `config STMPE_I2C` is `tristate` (drivers/mfd/Kconfig:1600), so a module license tag is appropriate. - Commit 9e646615df195 (2023) removed `MODULE_LICENSE` under the assumption the object was non‑modular, which was incorrect for this driver and led to the current regression (missing license). - This commit corrects that regression. - Affected stable series: In this tree, v6.6, v6.8, and v6.10 lack the license line (module taints if built as a module), while v6.1 still had `MODULE_LICENSE("GPL v2")`. Backport is beneficial to stable lines where the line is missing.
**Stable Criteria Fit** - Fixes a real, user-visible regression (kernel taint and GPL‑only symbol ineligibility) with a minimal, contained change. - No new features or API changes; confined to MFD stmpe I2C driver metadata. - Clear alignment with stable rules for small, low-risk fixes.
drivers/mfd/stmpe-i2c.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/stmpe-i2c.c b/drivers/mfd/stmpe-i2c.c index fe018bedab983..7e2ca39758825 100644 --- a/drivers/mfd/stmpe-i2c.c +++ b/drivers/mfd/stmpe-i2c.c @@ -137,3 +137,4 @@ module_exit(stmpe_exit);
MODULE_DESCRIPTION("STMPE MFD I2C Interface Driver"); MODULE_AUTHOR("Rabin Vincent rabin.vincent@stericsson.com"); +MODULE_LICENSE("GPL");