On Sat, Apr 02, 2022 at 04:20:59PM -0400, Michael S. Tsirkin wrote:
On Sat, Apr 02, 2022 at 09:03:29AM -0400, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
virtio_blk: eliminate anonymous module_init & module_exit
to the 5.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: virtio_blk-eliminate-anonymous-module_init-module_ex.patch and it can be found in the queue-5.17 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
I don't see how this patch qualifies for stable. Yes it's probably harmless but you never know what kind of script might be parsing e.g. System.map and changing that in the middle of stable seems like a bad idea to me.
I don't think that's a good reason to reject it, but I do think it doesn't fit with "fixes a bug" requirements. I'll drop this, and the other module_init patches from the stable queue now.
thanks,
greg k-h