On Apr 16, 2024 / 09:10, Chaitanya Kulkarni wrote:
On 4/12/2024 12:12 AM, Shinichiro Kawasaki wrote:
On Apr 10, 2024 / 23:39, Saranya Muruganandam wrote:
The BLKRRPART ioctl used to report errors such as EIO before we changed the blkdev_reread_part() logic.
Add a flag and capture the errors returned by bdev_disk_changed() when the flag is set. Set this flag for the BLKRRPART path when we want the errors to be reported when rereading partitions on the disk.
Link: https://lore.kernel.org/all/20240320015134.GA14267@lst.de/ Suggested-by: Christoph Hellwig hch@lst.de Tested: Tested by simulating failure to the block device and will propose a new test to blktests. Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part") Reported-by: Saranya Muruganandam saranyamohan@google.com Signed-off-by: Saranya Muruganandam saranyamohan@google.com
The change looks good to me. I also confirmed the fix with the new, corresponding blktests test case.
Reviewed-by: Shin'ichiro Kawasaki shinichiro.kawasaki@wdc.com Tested-by: Shin'ichiro Kawasaki shinichiro.kawasaki@wdc.com
which patch is the final one ? Is it this one or the one posted with title :-
"block: propagate partition scanning errors to the BLKRRPART ioctl​" ?
Please clarify so I can make sure to run some tests at my end.
The patch I reviewed and tested is the one that Saranya reflected my comment. It is found here:
https://lore.kernel.org/linux-block/20240410233932.256871-1-saranyamohan@goo...