Re: [PATCH net] net: wangxun: fix kernel panic due to null pointer

On Fri, Nov 17, 2023 at 06:11:08PM +0800, Jiawen Wu wrote:

When the device uses a custom subsystem vendor ID, the function wx_sw_init() returns before the memory of 'wx->mac_table' is allocated. The null pointer will causes the kernel panic.

Fixes: 79625f45ca73 ("net: wangxun: Move MAC address handling to libwx") Signed-off-by: Jiawen Wu jiawenwu@trustnetic.com

Thanks Jiawen Wu,

I agree with your analysis and that the problem was introduced by the cited commit. The fix also looks good to me.

Reviewed-by: Simon Horman horms@kernel.org