Re: [PATCH v4] blk-crypto: dynamically allocate fallback profile

On 8/10/23 13:24, Eric Biggers wrote:

On Thu, Aug 10, 2023 at 10:21:16AM -0400, Sweet Tea Dorminy wrote:

...

• /* Dynamic allocation is needed because of lockdep_register_key(). */
• blk_crypto_fallback_profile =

• kzalloc(sizeof(*blk_crypto_fallback_profile), GFP_KERNEL);
  

• if (!blk_crypto_fallback_profile) goto fail_free_bioset;

err needs to be set to -ENOMEM on failure here. See the suggestion I gave in v1

• Eric

Apologies; that's what I get for trying to rush out one more patch before going on a trip. Hopefully v5 is correct. Apologies again.