On 10/22/25 1:34 AM, Steev Klimaszewski wrote:
Hi Srini,
On the Thinkpad X13s, with this patchset applied, we end up seeing a NULL pointer dereference:
Thanks Steev, I think I know the issue, There was a silly typo in 3/4 patch. Could you please try this change, I will send this in v3 anyway;
-------------------------->cut<------------------------ diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c index 16bf09db29f5..6576b47a4c8c 100644 --- a/sound/soc/qcom/sdw.c +++ b/sound/soc/qcom/sdw.c @@ -31,6 +31,7 @@ static bool qcom_snd_is_sdw_dai(int id) case RX_CODEC_DMA_RX_6: case RX_CODEC_DMA_RX_7: case SLIMBUS_0_RX...SLIMBUS_6_TX: + return true; default: break; }
-------------------------->cut<------------------------
thanks, Srini> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020
Mem abort info: ESR = 0x0000000096000004 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 FSC = 0x04: level 0 translation fault Data abort info: ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 CM = 0, WnR = 0, TnD = 0, TagAccess = 0 GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 user pgtable: 4k pages, 48-bit VAs, pgdp=000000010abfe000 pgd=0000000000000000, p4d=0000000000000000 SMP pdr_interface(E) crc8(E) phy_qcom_qmp_pcie(E) icc_osm_l3(E) gpio_sbu_mux(E) qcom_wdt(E) typec(E) qcom_pdr_msg(E) qmi_helpers(E) smp2p(E) rpmsg_core(E) fixed(E) gpio_keys(E) qnoc_sc8280xp(E) pwm_bl(E) smem(E) efivarfs(E) CPU: 5 UID: 111 PID: 1501 Comm: wireplumber Tainted: G E 6.17.4 #2 PREEMPTLAZY Tainted: [E]=UNSIGNED_MODULE Hardware name: LENOVO 21BX0015US/21BX0015US, BIOS N3HET94W (1.66 ) 09/15/2025 pstate: 60401005 (nZCv daif +PAN -UAO -TCO -DIT +SSBS BTYPE=--) pc : sdw_stream_add_slave+0x4c/0x440 [soundwire_bus] lr : sdw_stream_add_slave+0x4c/0x440 [soundwire_bus] sp : ffff80008bc2b250 x29: ffff80008bc2b250 x28: ffff0000a56b2f88 x27: 0000000000000000 x26: 0000000000000000 x25: ffff0000a301b000 x24: 0000000000000000 x23: ffff0000e8ce0280 x22: 0000000000000000 x21: 0000000000000000 x20: ffff80008bc2b300 x19: ffff0000a305a880 x18: 0000000000000000 x17: 0000000000000000 x16: ffffb9859eb15c48 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 x11: 0000000000000000 x10: 0000000000000000 x9 : ffffb985391c0614 x8 : 0000000000000000 x7 : 0000000000000000 x6 : ffff0000a56b2fd0 x5 : ffff0000a56b2f80 x4 : 0000000000000000 x3 : 0000000000000000 x2 : ffff0000eb005000 x1 : 0000000000000000 x0 : ffff00011de2c890 Call trace: (P) wcd938x_sdw_hw_params+0xa8/0x200 [snd_soc_wcd938x_sdw] wcd938x_codec_hw_params+0x48/0x88 [snd_soc_wcd938x] snd_soc_dai_hw_params+0x44/0x90 [snd_soc_core] __soc_pcm_hw_params+0x230/0x620 [snd_soc_core] dpcm_be_dai_hw_params+0x260/0x888 [snd_soc_core] dpcm_fe_dai_hw_params+0xc4/0x3b0 [snd_soc_core] snd_pcm_hw_params+0x180/0x468 [snd_pcm] snd_pcm_common_ioctl+0xc00/0x18b8 [snd_pcm] snd_pcm_ioctl+0x38/0x60 [snd_pcm] __arm64_sys_ioctl+0xac/0x108 invoke_syscall.constprop.0+0x64/0xe8 el0_svc_common.constprop.0+0xc0/0xe8 do_el0_svc+0x24/0x38 el0_svc+0x3c/0x170 el0t_64_sync_handler+0xa0/0xf0 el0t_64_sync+0x198/0x1a0 Code: f9418c00 b9006fe3 91004000 97ffe306 (f8420f43) ---[ end trace 0000000000000000 ]---
-- steev