On 7/25/22 18:26, Alistair Popple wrote:
Thanks Ralph, please add:
Reviewed-by: Alistair Popple apopple@nvidia.com
However I think the fixes tag is wrong, see below.
Ralph Campbell rcampbell@nvidia.com writes:
If hmm_range_fault() is called with the HMM_PFN_REQ_FAULT flag and a device private PTE is found, the hmm_range::dev_private_owner page is used to determine if the device private page should not be faulted in. However, if the device private page is not owned by the caller, hmm_range_fault() returns an error instead of calling migrate_to_ram() to fault in the page.
Cc: stable@vger.kernel.org Fixes: 76612d6ce4cc ("mm/hmm: reorganize how !pte_present is handled in hmm_vma_handle_pte()")
This should be 08ddddda667b ("mm/hmm: check the device private page owner in hmm_range_fault()")
Looks better to me too. I assume Andrew will update the tags.