On Tue 2019-12-10 16:04:13, Sasha Levin wrote:
From: Ricardo Ribalda Delgado ribalda@kernel.org
[ Upstream commit 801ef7c4919efba6b96b5aed1e72844ca69e26d3 ]
Without this patch, media_device_register_entity throws a warning:
dev_warn(mdev->dev, "Entity type for entity %s was not initialized!\n", entity->name);
This fixes warning, not a serious bug. Thus it is against stable rules.
Please either update the rules to the real rules in use, or stop pushing such pages to stable.
Best regards, Pavel
index 925c171e77976..7a49651f4d1f2 100644 --- a/drivers/media/i2c/ad5820.c +++ b/drivers/media/i2c/ad5820.c @@ -309,6 +309,7 @@ static int ad5820_probe(struct i2c_client *client, v4l2_i2c_subdev_init(&coil->subdev, client, &ad5820_ops); coil->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; coil->subdev.internal_ops = &ad5820_internal_ops;
- coil->subdev.entity.function = MEDIA_ENT_F_LENS; strscpy(coil->subdev.name, "ad5820 focus", sizeof(coil->subdev.name));
ret = media_entity_pads_init(&coil->subdev.entity, 0, NULL); -- 2.20.1