* Alexandre Belloni alexandre.belloni@bootlin.com [210528 15:35]:
On 28/05/2021 16:04:46+0200, Thomas Petazzoni wrote:
In commit 92af4fc6ec33 ("usb: musb: Fix suspend with devices connected for a64"), the logic to support the MUSB_QUIRK_B_DISCONNECT_99 quirk was modified to only conditionally schedule the musb->irq_work delayed work.
This commit badly breaks ECM Gadget on AM335X. Indeed, with this commit, one can observe massive packet loss:
$ ping 192.168.0.100 ... 15 packets transmitted, 3 received, 80% packet loss, time 14316ms
Reverting this commit brings back a properly functioning ECM Gadget. An analysis of the commit seems to indicate that a mistake was made: the previous code was not falling through into the MUSB_QUIRK_B_INVALID_VBUS_91, but now it is, unless the condition is taken.
Changing the logic to be as it was before the problematic commit *and* only conditionally scheduling musb->irq_work resolves the regression:
$ ping 192.168.0.100 ... 64 packets transmitted, 64 received, 0% packet loss, time 64475ms
Fixes: 92af4fc6ec33 ("usb: musb: Fix suspend with devices connected for a64") Signed-off-by: Thomas Petazzoni thomas.petazzoni@bootlin.com
Tested-by: Alexandre Belloni alexandre.belloni@bootlin.com
Ouch, sorry about that one. And thanks for fixing it:
Acked-by: Tony Lindgren tony@atomide.com