Re: [PATCH wireless-drivers] brcmfmac: fix roamoff=1 modparam

Stijn Tintel stijn@linux-ipv6.be wrote:

When the update_connect_param callback is set, nl80211 expects the flag WIPHY_FLAG_SUPPORTS_FW_ROAM to be set as well. However, this flag is only set when modparam roamoff=0, while the callback is set unconditionally. Since commit 7f9a3e150ec7 this causes a warning in wiphy_register, which breaks brcmfmac.

Disable the update_connect_param callback when roamoff=0 to fix this.

Fixes: 7f9a3e150ec7 ("nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS") Cc: Stable stable@vger.kernel.org # 4.19+ Signed-off-by: Jonas Gorski jonas.gorski@gmail.com Signed-off-by: Stijn Tintel stijn@linux-ipv6.be

Should this go to 4.20? Arend?