On Thu Aug 15, 2024 at 9:34 PM EEST, Jarkko Sakkinen wrote:
On Mon Aug 12, 2024 at 11:25 AM EEST, Dmitrii Kuvaiskii wrote:
On Wed, Jul 17, 2024 at 01:38:59PM +0300, Jarkko Sakkinen wrote:
Ditto.
Just to be sure: I assume this means "Fixes should be in the head of the series so please reorder"? If yes, please see my reply in the other email [1].
OK, based on your earlier remarks and references I agree with you.
[1] https://lore.kernel.org/all/20240812082128.3084051-1-dmitrii.kuvaiskii@intel...
-- Dmitrii Kuvaiskii
I think for future and since we have bunch of state flags, removing that "e.g." is worth of doing. Often you need to go through all of the flags to remind you how they interact, and at that point "one vs many" does help navigating the complexity.
Actually every time there's a patch that has anything to do with the state flags I go through all of em as a reminder. Might seem like irrelevant detail but really is not (and neither unnecessarry nitpicking). All small clues speed up that process or can mislead.
BR, Jarkko