Re: [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in crc_t10dif_arch()

On Thu, Mar 27, 2025 at 07:58:51AM +0000, David Binderman wrote:

Hello there Eric,

...

Fix a silly bug where an array was used outside of its scope.

I am surprised your C compiler doesn't find this bug. gcc 14.2 onwards should be able to, but clang not.

I will make an enhancement request in clang.

Regards

David Binderman

Neither gcc 14.2.0 nor clang 19.1.7 found it, unfortunately. And the code still passed crc_kunit (even when run with have_pmull disabled so that the code is reached).

- Eric