Re: [PATCH 1/4] x86/of: Return consistent error type from x86_of_pci_irq_enable()

On Mon, May 27, 2024 at 03:55:35PM +0300, Ilpo Järvinen wrote:

x86_of_pci_irq_enable() returns PCIBIOS_* code received from pci_read_config_byte() directly and also -EINVAL which are not compatible error types. x86_of_pci_irq_enable() is used as (*pcibios_enable_irq) function which should not return PCIBIOS_* codes.

Convert the PCIBIOS_* return code from pci_read_config_byte() into normal errno using pcibios_err_to_errno().

Fixes: 96e0a0797eba ("x86: dtb: Add support for PCI devices backed by dtb nodes") Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Cc: stable@vger.kernel.org

Any particular reason why this is CC:stable?

I'd say unless you're fixing a specific failure, this should go the normal route to 6.11...