Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373

On Thu, Aug 19, 2021 at 8:18 AM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:

...

Apart from that, Maxim codecs go by the name of 'max' in sound/soc/codecs/. It's more intuitive to have equivalent shortcut used in board's name.

the ACPI HID start with MX and there's not much consistency in naming, is there?

            .drv_name = "kbl_r5514_5663_max",
            .drv_name = "kbl_rt5663_m98927",
            .drv_name = "kbl_da7219_mx98357a",
            .drv_name = "kbl_da7219_max98927",
            .drv_name = "kbl_max98373",

Reviewed-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

Agreed, it is definitely better to revisit and get it all in one go so we don't end up with a cherry-picking nightmare

Acked-by: Curtis Malainey cujomalainey@chromium.org