On Mon 30 Apr 10:34 PDT 2018, Nathan Chancellor wrote:
On Mon, Apr 30, 2018 at 10:21:11AM -0700, Bjorn Andersson wrote:
On Fri 27 Apr 00:35 PDT 2018, Nathan Chancellor wrote:
On Fri, Apr 27, 2018 at 09:05:21AM +0200, Greg KH wrote:
On Thu, Apr 26, 2018 at 09:50:25PM -0700, Nathan Chancellor wrote:
On Fri, Apr 27, 2018 at 02:01:20AM +0000, Sasha Levin wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi Greg,
Pleae pull commits for Linux 4.4 .
I've sent a review request for all commits over a week ago and all comments were addressed.
Thanks, Sasha
For what it's worth, commit 87a00850c711 ("pinctrl: msm: Use dynamic GPIO numbering") completely breaks touchscreen input on my Pixel 2 XL.
That's not good. Have you reported this to the gpio developers and authors of that patch?
I have not although I've gone ahead and CC'd them on this email.
Pixel 2XL is based on the Snapdragon 835, a DeviceTree-only platform; as such any GPIOs would be referenced by the touch driver using gpio-controller and pin offset.
What kind of touchscreen is this? Is there a driver for it available somewhere to look at?
Regards, Bjorn
Hi Bjorn,
Here is the touchscreen driver: https://android.googlesource.com/kernel/msm/+/android-msm-wahoo-4.4-oreo-m2/...
Here are the device tree files: https://android.googlesource.com/kernel/msm/+/android-msm-wahoo-4.4-oreo-m2/...
Thanks for the links. This driver doesn't depend on static gpio numbering, so there must be some other component causing your issues.
Do note that Timur stated in a later thread this patch is probably not suitable for stable but I'd be happy for a second opinion!
While it doesn't fix any regressions, base should have been -1 when the driver was originally merged, because one may not depend on the numbering of gpios.
Regards, Bjorn