Eric Biggers ebiggers@kernel.org writes:
On Thu, May 19, 2022 at 09:50:30AM +0100, David Howells wrote:
diff --git a/lib/assoc_array.c b/lib/assoc_array.c index 079c72e26493..ca0b4f360c1a 100644 --- a/lib/assoc_array.c +++ b/lib/assoc_array.c
Where are the tests for this file?
As of today there are none:
$ grep -lr assoc_array lib/assoc_array.c lib/Makefile lib/Kconfig arch/powerpc/mm/numa.c arch/powerpc/platforms/pseries/hotplug-memory.c Documentation/core-api/index.rst Documentation/core-api/assoc_array.rst Documentation/translations/zh_CN/core-api/index.rst Documentation/translations/zh_CN/core-api/assoc_array.rst include/linux/assoc_array.h include/linux/key.h include/linux/assoc_array_priv.h include/keys/keyring-type.h security/keys/internal.h security/keys/key.c security/keys/keyring.c security/keys/request_key.c
The assoc_array code is easy to get up and running in userspace (see the reproducer for this bug). So testing it would be feasible with some sort of userspace runner (KUnit?). Seems it hasn't been done yet.
Stephen
- Eric