Hello Osama,
On Fri Jan 2, 2026 at 4:55 PM CET, Osama Abdelkader wrote:
Fix several issues in dw_dp_bind() error handling:
Missing return after drm_bridge_attach() failure - the function continued execution instead of returning an error.
Resource leak: drm_dp_aux_register() is not a devm function, so drm_dp_aux_unregister() must be called on all error paths after aux registration succeeds. This affects errors from:
- drm_bridge_attach()
- phy_init()
- devm_add_action_or_reset()
- platform_get_irq()
- devm_request_threaded_irq()
Bug fix: platform_get_irq() returns the IRQ number or a negative error code, but the error path was returning ERR_PTR(ret) instead of ERR_PTR(dp->irq).
Use a goto label for cleanup to ensure consistent error handling.
Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library") Cc: stable@vger.kernel.org
Signed-off-by: Osama Abdelkader osama.abdelkader@gmail.com
Thank you for the improvements!
Reviewed-by: Luca Ceresoli luca.ceresoli@bootlin.com
Luca
-- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com