Hello Greg,
can you please revert this patch, without the corresponding driver patch [1] it breaks probing of the device, as no one populates the sub-nodes.
[1] 9cb6d1b39a8f ("soc: imx: imx8m-blk-ctrl: Scan subnodes and bind drivers to them")
Marc
On 08.05.2023 11:40:04, Greg Kroah-Hartman wrote:
From: Marek Vasut marex@denx.de
[ Upstream commit 5a51e1f2b083423f75145c512ee284862ab33854 ]
This block should not be compatible with simple-bus and misuse it that way. Instead, the driver should scan its subnodes and bind drivers to them.
Reviewed-by: Alexander Stein alexander.stein@ew.tq-group.com Reviewed-by: Liu Ying victor.liu@nxp.com Tested-by: Alexander Stein alexander.stein@ew.tq-group.com Fixes: 94e6197dadc9 ("arm64: dts: imx8mp: Add LCDIF2 & LDB nodes") Signed-off-by: Marek Vasut marex@denx.de Signed-off-by: Shawn Guo shawnguo@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index a237275ee0179..3f9d67341484b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1151,7 +1151,7 @@ media_blk_ctrl: blk-ctrl@32ec0000 { compatible = "fsl,imx8mp-media-blk-ctrl",
"simple-bus", "syscon";
"syscon"; reg = <0x32ec0000 0x10000>; #address-cells = <1>; #size-cells = <1>;
-- 2.39.2