On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote:
On 2023-10-31 07:48, Greg KH wrote:
On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
This patch addresses the following warning spotted by using coccinelle where the case checked does the same than the else case.
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32")
Cc: stable@vger.kernel.org
Why is this relevant for stable?
Hi, I was asked to send it for stable because this codelooks different in amd-staging-drm-next, see here.
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drive...
I don't know what I am looking at, sorry.
Feel free to let me know if this is wrong, or if Ineed to review some other guidelines I may have missed.
Please see the list of rules for stable patches: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
Does "remove code that does nothing" fit here?
thanks,
greg k-h