Re: [PATCH v4] mailbox: pcc: Add missed acpi_put_table() to fix memory leak

On Thu, Aug 07, 2025 at 07:10:35PM +0530, Aithal, Srikanth wrote:

Hello,

This commit, now part of next-20250807[1], is causing kernel boot crash on AMD EPYC Milan platform.

commit c3f772c384c8ec0796a73c80f89a31ff862c1295 (HEAD) Author: Zhen Ni zhen.ni@easystack.cn Date: Tue Aug 5 11:48:29 2025 +0800

mailbox: pcc: Add missed acpi_put_table() to fix memory leak

Fixes a permanent ACPI memory leak in the success path by adding
acpi_put_table().
Renaming generic 'err' label to 'put_table' for clarity.

Fixes: ce028702ddbc ("mailbox: pcc: Move bulk of PCCT parsing into

pcc_mbox_probe") Cc: stable@vger.kernel.org Signed-off-by: Zhen Ni zhen.ni@easystack.cn Signed-off-by: Jassi Brar jassisinghbrar@gmail.com

Attaching both the dmesg and kernel config here.

If I go back 1 commit [i.e 75f1fbc9fd409a0c232dc78871ee7df186da9d57], things work fine.

Thanks for the report. I analysed the report and concluded that we can't drop the reference to the table unless we may a copy of some GAS registers as we access them at runtime.

Zhen,

Sorry, I must withdraw my Reviewed-by.