Re: [PATCH] scsi: core: initialize cmd->cmnd before it is used

On 11/1/21 13:06, Bart Van Assche wrote:

This patch is a duplicate and has been posted before.

Please take a look at https://lore.kernel.org/linux-scsi/20210904064534.1919476-1-qiulaibin@huawei.... From the replies to that email: "> Thinking further about this: is there any code left that depends on

...

scsi_setup_scsi_cmnd() setting cmd->cmd_len? Can the cmd->cmd_len assignment be removed from scsi_setup_scsi_cmnd()?

cmd_len should never be 0 now, so I think we can remove it."

Thanks for quick response, but I'm not sure if statement "cmd_len should never be 0 now" is correct, because the cmd_len is in fact equal to 0 here and this BUG can be triggered on mainline, 5.14, and 5.10 stable kernels.