Re: [PATCH 1/3] drm/ast: Set DDC timeout in milliseconds

-- Jocelyn On 03/04/2024 12:31, Thomas Zimmermann wrote: > Compute the i2c timeout in jiffies from a value in milliseconds. The > original values of 2 jiffies equals 2 milliseconds if HZ has been > configured to a value of 1000. This corresponds to 2.2 milliseconds > used by most other DRM drivers. Update ast accordingly. > > Signed-off-by: Thomas Zimmermann tzimmermann@suse.de > Fixes: 312fec1405dd ("drm: Initial KMS driver for AST (ASpeed Technologies) 2000 series (v2)") > Cc: Dave Airlie airlied@redhat.com > Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com > Cc: Maxime Ripard mripard@kernel.org > Cc: Thomas Zimmermann tzimmermann@suse.de > Cc: Jocelyn Falempe jfalempe@redhat.com > Cc: dri-devel@lists.freedesktop.org > Cc: stable@vger.kernel.org # v3.5+ > --- > drivers/gpu/drm/ast/ast_ddc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ast/ast_ddc.c b/drivers/gpu/drm/ast/ast_ddc.c > index b7718084422f3..3e156a6b6831d 100644 > --- a/drivers/gpu/drm/ast/ast_ddc.c > +++ b/drivers/gpu/drm/ast/ast_ddc.c > @@ -153,7 +153,7 @@ struct ast_ddc *ast_ddc_create(struct ast_device *ast) > > bit = &ddc->bit; > bit->udelay = 20; > - bit->timeout = 2; > + bit->timeout = usecs_to_jiffies(2200); > bit->data = ddc; > bit->setsda = ast_ddc_algo_bit_data_setsda; > bit->setscl = ast_ddc_algo_bit_data_setscl;