From: Ryan Chen ryan_chen@aspeedtech.com
[ Upstream commit c30dcfd4b5a0f0e3fe7138bf287f6de6b1b00278 ]
Extend the ASPEED SoC info driver to support AST27XX silicon IDs.
Signed-off-by: Ryan Chen ryan_chen@aspeedtech.com Link: https://patch.msgid.link/20250807005208.3517283-1-ryan_chen@aspeedtech.com Signed-off-by: Andrew Jeffery andrew@codeconstruct.com.au Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
## Backport Analysis: soc: aspeed: socinfo: Add AST27xx silicon IDs
**Backport Status: YES**
### Executive Summary This commit **should be backported** to stable kernel trees and has **already been selected** for backporting by the AUTOSEL process (commit ae11b34ee41dc). The change is explicitly permitted by stable kernel rules and follows established precedent.
### Detailed Analysis
#### 1. **Compliance with Stable Kernel Rules** The stable kernel documentation (Documentation/process/stable-kernel- rules.rst:15) explicitly states:
"It must either fix a real bug that bothers people **or just add a
device ID**."
This commit adds silicon IDs (which are device IDs) for the AST2700 series SoCs. **This type of change is explicitly permitted by stable kernel policy.**
#### 2. **Code Change Analysis** The change in drivers/soc/aspeed/aspeed-socinfo.c:27-30 adds only 4 lines to a static lookup table: ```c + /* AST2700 */ + { "AST2750", 0x06000003 }, + { "AST2700", 0x06000103 }, + { "AST2720", 0x06000203 }, ```
**Risk Assessment:** - **Size**: 4 lines (well under 100-line limit) - **Complexity**: Pure data addition, no logic changes - **Dependencies**: None - **Regression risk**: Zero - only affects AST2700 hardware identification - **Side effects**: None - if these IDs don't match, lookup returns "Unknown" as before
#### 3. **Silicon ID Pattern Validation** The IDs follow ASPEED's established pattern: - **0x06** = Generation 6 (AST2700 series) - **0x00** = Model family - **0x00/01/02** = Variant differentiation (2750/2700/2720) - **0x03** = Revision A3
This is consistent with all previous ASPEED silicon IDs (AST2400-AST2625).
#### 4. **Historical Precedent** **Commit d0e72be77e799** (2021) added AST2605 support with a `Fixes:` tag and was backported to stable 5.11.x by Sasha Levin. This establishes clear precedent that adding missing silicon IDs is considered a fix, not a new feature.
**Commit 8812dff6459dd** (2021) added AST2625 variant without stable tags but was included in mainline 5.15-rc1.
#### 5. **Current Status** - **Original commit**: c30dcfd4b5a0f (merged in aspeed-6.18-drivers-0 tag) - **AUTOSEL backport**: ae11b34ee41dc (signed by Sasha Levin) - **Status**: Already selected for stable backporting - **Fixes/Reverts**: None found since merge
#### 6. **AST2700 Context in v6.17** Device tree bindings for AST2700 already exist in v6.17: - `Documentation/devicetree/bindings/interrupt- controller/aspeed,ast2700-intc.yaml` - `Documentation/devicetree/bindings/mailbox/aspeed,ast2700- mailbox.yaml` - `Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml` (mentions AST2700)
This means v6.17 has partial AST2700 support. Adding silicon IDs enables proper SoC identification for users with AST2700 hardware.
#### 7. **User Impact** **Without this patch:** Users running stable kernels on AST2700 hardware see: ``` ASPEED Unknown rev ?? (06000003) ```
**With this patch:** Users see proper identification: ``` ASPEED AST2750 rev A3 (06000003) ```
This matters for: - Hardware identification and inventory - Debugging and support - Kernel boot logs and diagnostics - System management tools
#### 8. **Why Backport Despite No "Fixes:" Tag?** While the original commit lacks explicit stable tags, it qualifies because: 1. **Stable rules explicitly permit device ID additions** (no Fixes tag required) 2. **AUTOSEL process selected it** (automated stable selection) 3. **Zero regression risk** with clear user benefit 4. **Completes existing AST2700 support** already present in v6.17
### Conclusion **YES - This commit should be backported.** It meets all stable kernel criteria, has already been selected by AUTOSEL, carries zero regression risk, and provides tangible value to users with AST2700 hardware on stable kernels. The stable kernel rules explicitly permit device ID additions, making this an appropriate and safe backport candidate.
drivers/soc/aspeed/aspeed-socinfo.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c index 3f759121dc00a..67e9ac3d08ecc 100644 --- a/drivers/soc/aspeed/aspeed-socinfo.c +++ b/drivers/soc/aspeed/aspeed-socinfo.c @@ -27,6 +27,10 @@ static struct { { "AST2620", 0x05010203 }, { "AST2605", 0x05030103 }, { "AST2625", 0x05030403 }, + /* AST2700 */ + { "AST2750", 0x06000003 }, + { "AST2700", 0x06000103 }, + { "AST2720", 0x06000203 }, };
static const char *siliconid_to_name(u32 siliconid)