Re: [PATCH v3 2/5] Bluetooth: add quirk for broken address properties

On Tue, Mar 19, 2024 at 09:10:23AM -0700, Doug Anderson wrote:

On Tue, Mar 19, 2024 at 8:29 AM Johan Hovold johan+linaro@kernel.org wrote:

...

•   /* When this quirk is set, the Bluetooth Device Address provided by
  

•    * the 'local-bd-address' fwnode property is incorrectly specified in
  

•    * big-endian order.
  

•    *
  

•    * This quirk can be set before hci_register_dev is called or
  

•    * during the hdev->setup vendor callback.
  

•    */
  

•   HCI_QUIRK_BDADDR_PROPERTY_BROKEN,
  

Like with the binding, I feel like "HCI_QUIRK_BDADDR_PROPERTY_BACKWARDS" or "HCI_QUIRK_BDADDR_PROPERTY_SWAPPED" would be more documenting but I don't feel strongly.

So, same reasoning here, this it not some quirk that people should go around setting without first considering to fix their boot firmware.

Johan