Re: [PATCH v2 1/4] mm: hugetlb: Add huge page size param to huge_ptep_get_and_clear()

On Tue, Feb 25, 2025 at 03:43:04PM +0000, Ryan Roberts wrote:

...

...

+pte_t huge_ptep_get_and_clear(struct mm_struct *mm,

• 	      unsigned long addr, pte_t *ptep, unsigned long sz)
  

+{

• return __huge_ptep_get_and_clear(mm, addr, ptep);

+}

Is there a reason why this is not a header inline, as other callers of __huge_ptep_get_and_clear()?

I was trying to make the change as uninvasive as possible, so didn't want to change the linkage in case I accidentally broke something. Happy to make this an inline in the header though, if you prefer?

Yes, please.

Thanks, Ryan

Thanks!