Re: [PATCH] ext4: fix leaking sysfs kobject after failed mount

On Thu, Sep 24, 2020 at 11:08:59AM +0200, Jan Kara wrote:

On Tue 22-09-20 09:24:56, Eric Biggers wrote:

...

From: Eric Biggers ebiggers@google.com

ext4_unregister_sysfs() only deletes the kobject. The reference to it needs to be put separately, like ext4_put_super() does.

This addresses the syzbot report "memory leak in kobject_set_name_vargs (3)" (https://syzkaller.appspot.com/bug?extid=9f864abad79fae7c17e1).

Reported-by: syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com Fixes: 72ba74508b28 ("ext4: release sysfs kobject when failing to enable quotas on mount") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers ebiggers@google.com

Looks good. You can add:

Reviewed-by: Jan Kara jack@suse.cz

Thanks, applied.

- Ted