On Fri, Oct 25, 2024 at 02:05:26PM +0100, Marc Zyngier wrote:
Mark Brown broonie@kernel.org wrote:
I'm not even sure that's a terrible fix, looking at the changelog I get the impression the test is deliberately looking to do problematic things with the goal of making sure that the kernel handles them appropriately. That's not interacting well with the KVM selftest framework's general assert early assert often approach but it's a reasonable thing to want to test so relaxing the asserts like this is one way of squaring the circile.
It *is* a terrible fix, since it makes no effort in finding out whether the VM is be dead for a good or a bad reason. In a way, the fix is worse than the current error, because it silently hide the crap.
I mean, it's clearly not ideal or finished especially in that it's just allowing the error code throughout the program rather than during a specific case but the broad approach of flagging that the VM is expected to already be in a bad state and not support operations any more seems reasonable.