Re: [PATCH v2 03/13] ata: ahci: Clean up sysfs file on error

On Wed, Jun 26, 2024 at 08:00:33PM +0200, Niklas Cassel wrote:

.probe() (ahci_init_one()) calls sysfs_add_file_to_group(), however, if probe() fails after this call, we currently never call sysfs_remove_file_from_group().

(The sysfs_remove_file_from_group() call in .remove() (ahci_remove_one()) does not help, as .remove() is not called on .probe() error.)

Thus, if probe() fails after the sysfs_add_file_to_group() call, we get:

Nit: s/we get/the next time we insmod the module we will get/