Re: [PATCH 4.19 200/321] mm/page_alloc.c: deduplicate __memblock_free_early() and memblock_free()

Hi! On Tue 2019-12-03 23:34:26, Greg Kroah-Hartman wrote:

From: Wentao Wang witallwang@gmail.com

[ Upstream commit d31cfe7bff9109476da92c245b56083e9b48d60a ]

@@ -1537,12 +1537,7 @@ void * __init memblock_virt_alloc_try_nid( */ void __init __memblock_free_early(phys_addr_t base, phys_addr_t size) {

• phys_addr_t end = base + size - 1;
• memblock_dbg("%s: [%pa-%pa] %pF\n",

•      __func__, &base, &end, (void *)_RET_IP_);
  

• kmemleak_free_part_phys(base, size);
• memblock_remove_range(&memblock.reserved, base, size);

• memblock_free(base, size);

}

This makes the memblock_dbg() less useful: _RET_IP_ will now be one of __memblock_free_early(), not of the original caller.

That may be okay, but I guess it should be mentioned in changelog, and I don't really see why it is queued for -stable.

Best regards, Pavel