Re: [PATCH v5] scsi: sd: Ignore command SYNC CACHE error if format in progress

On 8/19/24 2:09 AM, Yihang Li wrote:

• 	if ((sshdr.asc == 0x04 && sshdr.ascq == 0x04) ||
  

Shouldn't symbolic names be introduced for these numeric constants? Although there is more code in the SCSI core that compares ASC / ASCQ values with numeric constants, I think we need symbolic names for these constants to make code like the above easier to read. There is already a header file for definitions that come directly from the SCSI standard and that is used by both SCSI initiator and SCSI target code: <scsi/scsi_proto.h>.

Thanks,

Bart.