[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected. No action required from the submitter.
The upstream commit SHA1 provided is correct: e4f949ef1516c0d74745ee54a0f4882c1f6c7aea
WARNING: Author mismatch between patch and upstream commit: Backport author: Xiangyu Chenxiangyu.chen@eng.windriver.com Commit author: Igor Pylypivipylypiv@google.com
Status in newer kernel trees: 6.15.y | Present (exact SHA1) 6.12.y | Present (exact SHA1) 6.6.y | Present (different SHA1: 7b1d779647af)
Note: The patch differs from the upstream commit: --- 1: e4f949ef1516c ! 1: b784aa07fb1ca scsi: pm80xx: Set phy->enable_completion only when we wait for it @@ Metadata ## Commit message ## scsi: pm80xx: Set phy->enable_completion only when we wait for it
+ [ Upstream commit e4f949ef1516c0d74745ee54a0f4882c1f6c7aea ] + pm8001_phy_control() populates the enable_completion pointer with a stack address, sends a PHY_LINK_RESET / PHY_HARD_RESET, waits 300 ms, and returns. The problem arises when a phy control response comes late. After @@ Commit message Link: https://lore.kernel.org/r/20240627155924.2361370-2-tadamsjr@google.com Acked-by: Jack Wang jinpu.wang@ionos.com Signed-off-by: Martin K. Petersen martin.petersen@oracle.com + Signed-off-by: Xiangyu Chen xiangyu.chen@windriver.com + Signed-off-by: He Zhe zhe.he@windriver.com
## drivers/scsi/pm8001/pm8001_sas.c ## @@ drivers/scsi/pm8001/pm8001_sas.c: int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func, @@ drivers/scsi/pm8001/pm8001_sas.c: int pm8001_phy_control(struct asd_sas_phy *sas pm8001_ha = sas_phy->ha->lldd_ha; phy = &pm8001_ha->phy[phy_id]; - pm8001_ha->phy[phy_id].enable_completion = &completion; - - if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) { - /* ++ + switch (func) { + case PHY_FUNC_SET_LINK_RATE: + rates = funcdata; @@ drivers/scsi/pm8001/pm8001_sas.c: int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func, rates->maximum_linkrate; } ---
Results of testing on various branches:
| Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-6.1.y | Success | Success |