On Mon, Nov 07, 2022 at 06:09:12AM -0500, Brian Masney wrote:
On Fri, Nov 04, 2022 at 10:20:44AM +0100, Johan Hovold wrote:
There are three UFS reference clocks on SC8280XP which are used as follows:
The GCC_UFS_REF_CLKREF_CLK clock is fed to any UFS device connected to either controller.
The GCC_UFS_1_CARD_CLKREF_CLK and GCC_UFS_CARD_CLKREF_CLK clocks provide reference clocks to the two PHYs.
Note that this depends on first updating the clock driver to reflect that all three clocks are sourced from CXO. Specifically, the UFS controller driver expects the device reference clock to have a valid frequency:
ufshcd-qcom 1d84000.ufs: invalid ref_clk setting = 0
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Fixes: 8d6b458ce6e9 ("arm64: dts: qcom: sc8280xp: fix ufs_card_phy ref clock") Fixes: f3aa975e230e ("arm64: dts: qcom: sc8280xp: correct ref clock for ufs_mem_phy") Link: https://lore.kernel.org/lkml/Y2OEjNAPXg5BfOxH@hovoldconsulting.com/ Cc: stable@vger.kernel.org # 5.20 Signed-off-by: Johan Hovold johan+linaro@kernel.org
Reviewed-by: Brian Masney bmasney@redhat.com
Note that there was no 5.20 kernel; that should be 6.0. Bjorn should be able to fix this up during merge.
Good catch. I based this on a tag created before 6.0 was released and failed to notice.
Johan