Re: commit b079d3775237 in 5.15.y

On Tue, Dec 20, 2022 at 10:16:38AM +0100, Rasmus Villemoes wrote:

Hi,

I think something went slightly wrong when 7c7f9bc98 (serial: Deassert Transmit Enable on probe in driver-specific way) got backported to 5.15.y. In fsl_lpuart.c, the original had this

failed_irq_request: -failed_get_rs485: uart_remove_one_port(&lpuart_reg, &sport->port); failed_attach_port: +failed_get_rs485: failed_reset: lpuart_disable_clks(sport); return ret;

in the error path, but that is missing in the backport. So if we now hit the 'goto failed_get_rs485;', we'll do uart_remove_one_port() while uart_add_one_port() hasn't been done.

Ick, can you send a patch to fix this up?

thanks,

greg k-h