On 7/29/25 12:17 PM, Michał Pecio wrote:
Hi,
Hi,
On Sun, 27 Jul 2025 17:44:16 +0200, Marek Vasut wrote:
Increase the External ROM access timeouts to prevent failures during programming of External SPI EEPROM chips. The current timeouts are too short for some SPI EEPROMs used with uPD720201 controllers.
The current timeout for Chip Erase in renesas_rom_erase() is 100 ms , the current timeout for Sector Erase issued by the controller before Page Program in renesas_fw_download_image() is also 100 ms. Neither timeout is sufficient for e.g. the Macronix MX25L5121E or MX25V5126F.
Out of curiosity, who uses this ROM update functionality and why?
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts
The factory will likely use this code path to preload the SPI EEPROM during board production and testing.
It seems weird to write nonvolatile memories in a PCI probe routine. Boards or PCIe cards fitted with ROMs are programmed with working firmware at the factory and there ought to be no need to touch that.
See above.
And if you want to update this FW, dropping a file in /lib/firmware/ and loading a kernel module is not the usual (or convenient) UI...
See above.