Re: [PATCH 4.19 01/80] net: dsa: Do not make user port errors fatal

Hi!

From: Florian Fainelli f.fainelli@gmail.com

commit 86f8b1c01a0a537a73d2996615133be63cdf75db upstream.

Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would not treat failures to set-up an user port as fatal, but after this commit we would, which is a regression for some systems where interfaces may be declared in the Device Tree, but the underlying hardware may not be present (pluggable daughter cards for instance).

+++ b/net/dsa/dsa2.c @@ -412,7 +412,7 @@ static int dsa_tree_setup_switches(struc err = dsa_switch_setup(ds); if (err)

• 	return err;
  

• 	continue;
  

The error code is discarded here, so user can now wonder "why does not my port work" with no indications in the logs... Should we do dev_info() here?

Best regards, Pavel